Check if any gateways exist before iterating#7960
Closed
jiuka wants to merge 1 commit intoopnsense:masterfrom
Closed
Check if any gateways exist before iterating#7960jiuka wants to merge 1 commit intoopnsense:masterfrom
jiuka wants to merge 1 commit intoopnsense:masterfrom
Conversation
Member
|
Hi @jiuka, Thanks for the details. I currently fail to reproduce this locally no matter what data I try to push there. I do expect some remaining issues from the gateway MVC conversion (and gateway groups not having followed yet), but I'd like to be careful with breaking this area even though your fix looks reasonable the problem could be worse and masked using this change. Cheers, |
6586a65 to
607e32a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
Describe the bug
On a fresh OPNsense configuration the key
/opnsense/gatewaysdoes not exist in the config.xml. If a Gateway is created and then deleted an error is raise.To delete the gateway a gateway group needs to be createt (and can be deleted again). This leafs the following in the
config.xml.To Reproduce
Steps to reproduce the behavior:
gatewaysnode fromconfig.xmlExpected behavior
The gateway should be deleted.
Describe alternatives you considered
Screenshots
Relevant log files
Additional context
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 24.7.6-amd64